Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-24042]. Kafka Service Check failed on https enabled/WE cluster … #1477

Merged
merged 1 commit into from Jun 6, 2018

Conversation

zeroflag
Copy link
Contributor

@zeroflag zeroflag commented Jun 6, 2018

…after Ambari Upgrade. Error : Failed to check that topic exists (amagyar)

What changes were proposed in this pull request?

There is a kafka property (kafka-broker/delete.topic.enable) that controls whether deleting a topic via the admin tool is allowed or not. If this property is set to false, ambari service check is not able to delete a test topic and fails.

I added a check which makes the service to skip the topic create/delete operations and only list topic will be used to check if kafka is ok.

How was this patch tested?

  • set delete.topic.enable to false and verified that the service check returned early without trying to create/delete the topic
  • set delete.topic.enabled to true and verified that the service check worked as before

…after Ambari Upgrade. Error : Failed to check that topic exists (amagyar)
@zeroflag zeroflag self-assigned this Jun 6, 2018
@zeroflag zeroflag requested review from a user, rlevas, mradha25 and smolnar82 June 6, 2018 11:48
@asfgit
Copy link

asfgit commented Jun 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2615/
Test PASSed.

@zeroflag zeroflag merged commit 1bd7cdb into apache:trunk Jun 6, 2018
@zeroflag zeroflag deleted the AMBARI-24042-trunk branch June 6, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants