Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-24217] Blueprint deployment with custom service name #1692

Merged

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Blueprint syntax allows specifying custom service name for components (eg. zk
instead of ZOOKEEPER) using the service_instance property, but deployment
fails.

This fix addresses the backend issues (server and agent) that caused the
failure. Note that the UI still doesn't handle custom service names.

How was this patch tested?

Tested blueprint deployment both with custom name and using default names.
Verified service name via API.

$ curl http://${AMBARI_SERVER}:8080/api/v1/clusters/TEST/servicegroups/HDPCORE/services
{
  "items" : [
    {
      "ServiceInfo" : {
        "cluster_name" : "TEST",
        "service_group_name" : "HDPCORE",
        "service_name" : "zokeppar"
      }
    }
  ]
}

$ curl http://${AMBARI_SERVER}:8080/api/v1/clusters/TEST/servicegroups/HDPCORE/services/zokeppar/components
{
  "items" : [
    {
      "ServiceComponentInfo" : {
        "cluster_name" : "TEST",
        "component_name" : "ZOOKEEPER_SERVER",
        "service_group_name" : "HDPCORE",
        "service_name" : "zokeppar"
      }
    }
  ]
}

@adoroszlai adoroszlai self-assigned this Jul 6, 2018
@asfgit
Copy link

asfgit commented Jul 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2994/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Jul 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3002/
Test FAILed.
Test FAILured.

Copy link
Contributor

@rnettleton rnettleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks fine to me, just a minor question/comment.

Could you also please ask @mpapirkovskyy (for the STOMP-related changes) to review this change?

*
* @return collection of all represented service names
* @return collection of all represented service types
*/
Collection<String> getServices();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider changing the name of this method as well, to make it clear that service types are now being returned from this method, rather than service names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, renamed to getServiceTypes.

@adoroszlai
Copy link
Contributor Author

Hi @scottduan, can you please review the change to execution_command? Thanks.

@asfgit
Copy link

asfgit commented Jul 11, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3076/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Jul 11, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3077/
Test FAILed.
Test FAILured.

@adoroszlai adoroszlai merged commit 1d24700 into apache:branch-feature-AMBARI-14714 Jul 11, 2018
@adoroszlai adoroszlai deleted the AMBARI-24217 branch July 11, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants