-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMBARI-24217] Blueprint deployment with custom service name #1692
[AMBARI-24217] Blueprint deployment with custom service name #1692
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch looks fine to me, just a minor question/comment.
Could you also please ask @mpapirkovskyy (for the STOMP-related changes) to review this change?
* | ||
* @return collection of all represented service names | ||
* @return collection of all represented service types | ||
*/ | ||
Collection<String> getServices(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider changing the name of this method as well, to make it clear that service types are now being returned from this method, rather than service names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, renamed to getServiceTypes
.
Hi @scottduan, can you please review the change to |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
What changes were proposed in this pull request?
Blueprint syntax allows specifying custom service name for components (eg.
zk
instead of
ZOOKEEPER
) using theservice_instance
property, but deploymentfails.
This fix addresses the backend issues (server and agent) that caused the
failure. Note that the UI still doesn't handle custom service names.
How was this patch tested?
Tested blueprint deployment both with custom name and using default names.
Verified service name via API.