[AMBARI-22826] Mpack related changes to Add Hosts Page (ishanbha) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
vivekratnavel
changed the title
ishanbha
requested review from
vivekratnavel,
Jetly-Jaimin,
atkach,
aBabiichuk and
aleksandrkovalenko
atkach
reviewed
Jan 25, 2018
| this.get('inputtedAgainHostNames').push(hostNameArr[i]); | ||
| var tempArr = []; | ||
| if (this.get('manualInstall')) { | ||
| this.get('manuallyInstalledHosts').forEach ( function (host) { |
There was a problem hiding this comment.
You can use mapProperty('hostName')
atkach
reviewed
Jan 25, 2018
| if(arr.length <= 1) { | ||
| return arr.toString(); | ||
| } | ||
| var formattedText = ""; |
atkach
reviewed
Jan 25, 2018
| if (filter) { | ||
| filter = filter.toUpperCase(); | ||
| } | ||
| this.get('controller.manuallyInstalledHosts').forEach(function (host) { |
There was a problem hiding this comment.
We are trying to minimize directly changing DOM nodes, use class binding instead.
There was a problem hiding this comment.
@atkach But here I need to dynamically set display to none or block based on what is being typed in the filter box for each item in the list. I thought fetching by id is quick. How do I bind each item in the list to a class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changes to be made for the Add Hosts Page including changes to the manual registration of hosts, registration using ssh and table display for the pre-registered hosts.
How was this patch tested?
Previous tests were modified/removed. New tests were added. All unit tests pass.
20392 passing (21s)
125 pending
Please review Ambari Contributing Guide before opening a pull request.
@atkach @hiveww @Jetly-Jaimin @vivekratnavel