Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-24310] UI sends host check request for custom jdk with invalid hosts #1801

Merged
merged 1 commit into from Jul 19, 2018

Conversation

aBabiichuk
Copy link
Contributor

What changes were proposed in this pull request?

UI sends "java_home_check" host check with all populated hosts instead hosts with passed registration only. This can cause 500 server exception due HostNotFoundException.

2018-07-05 14:10:30,930 ERROR [ambari-client-thread-573] AbstractResourceProvider:295 - Caught AmbariException when creating a resource
org.apache.ambari.server.HostNotFoundException: Host not found, hostname=test-0000
        at org.apache.ambari.server.state.cluster.ClustersImpl.getHost(ClustersImpl.java:456)
        at org.apache.ambari.server.state.ConfigHelper.getEffectiveDesiredTags(ConfigHelper.java:189)
        at org.apache.ambari.server.state.ConfigHelper.getEffectiveDesiredTags(ConfigHelper.java:173)
        at org.apache.ambari.server.controller.AmbariManagementControllerImpl.findConfigurationTagsWithOverrides(AmbariManagementControllerImpl.java:2353)
POST http://host:8080/api/v1/requests 500 (Internal Server Error)
send @ vendor.js:8630
jQuery.extend.ajax @ vendor.js:8082
send @ app.js:192735
doCheckJDK @ app.js:41241
(anonymous function) @ app.js:41318
fire @ vendor.js:1141
self.fireWith @ vendor.js:1252
done @ vendor.js:8178
callback @ vendor.js:8702

Body of request:

{"RequestInfo":{"context":"Check hosts","action":"check_host","parameters":{"threshold":"60","java_home":"/tmp/jdk1.8.0_171/","jdk_location":"http://host:8080/resources","check_execute_list":"java_home_check"}},"Requests/resource_filters":[{"hosts":"test-0000,test-0001,test-0002,...

How was this patch tested?

21797 passing (25s)
48 pending

@aBabiichuk aBabiichuk added web client Ambari WebUI Client cherry-pick labels Jul 19, 2018
@aBabiichuk aBabiichuk self-assigned this Jul 19, 2018
@asfgit
Copy link

asfgit commented Jul 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3168/
Test FAILed.
Test FAILured.

@aBabiichuk
Copy link
Contributor Author

retest this please

@asfgit
Copy link

asfgit commented Jul 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3175/
Test PASSed.

@aBabiichuk aBabiichuk merged commit 4b3611f into apache:branch-2.7 Jul 19, 2018
@aBabiichuk aBabiichuk deleted the AMBARI-24310-branch-2.7 branch July 19, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick web client Ambari WebUI Client
Projects
None yet
2 participants