AMBARI-24386 - [Log Search] Input config validator unable to parse any log entry #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroflag
approved these changes
Jul 31, 2018
|
Refer to this link for build results (access rights to CI server needed): |
oleewere
approved these changes
Jul 31, 2018
kasakrisz
added a commit
to kasakrisz/ambari
that referenced
this pull request
Jul 31, 2018
kasakrisz
added a commit
that referenced
this pull request
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
On LogSearch UI on the "Configuration Editor" page the input config validator could not parse any log entries because of an NPE. The LogEntryParseTester.parse method creates its own instance of OutputManagerImpl which depends on LogFeederProps. LogFeederProps was not set.
How was this patch tested?
Manually:
Deploy a cluster including zookeeper, infra-solr and logsearch.
Login to Logsearch portal
Select "Configuration Editor" from the right upper corner menu
Select an input config from "All Configuration" (ambari)
Enter a "Component Name" on the "Validator" section (ambari_agent)
Enter a log entry to the "Sample Data" text area
INFO 2018-07-31 06:14:06,550 security.py:67 - SSL connection established. Two-way SSL authentication is turned off on the server.Click "Test"
The UI indicates that the "Configuration is valid."