[AMBARI-22826] Mpack related changes to Add Hosts Page. #200
Conversation
ishanbha
requested review from
vivekratnavel,
Jetly-Jaimin,
atkach,
aBabiichuk and
aleksandrkovalenko
| } | ||
| this.get('controller.manuallyInstalledHosts').forEach(function (host) { | ||
| var element = self.$('tr[id="' + host.hostName + '"]') | ||
| if (element) { |
There was a problem hiding this comment.
@atkach I am changing the display of each item in the list to none or block based on what is being entered in the filter box. DOM being fetched on the basis of id. Do you think there is a way to use class bindings in this scenario. Please suggest.
There was a problem hiding this comment.
For example, define host as an object with the flag "isFiltered", in the template:
{{#each host in view.hosts}}
<tr {{bindAttr class="host.isFiltered::hidden"}}>
|
Refer to this link for build results (access rights to CI server needed): |
| installedHosts.push({ | ||
| 'hostName': item.Hosts.host_name, | ||
| 'cpuCount': item.Hosts.cpu_count, | ||
| 'memory': (parseFloat(item.Hosts.total_mem) * 0.000001).toFixed(2) + " GB", |
There was a problem hiding this comment.
If values in kb, conversion should be {KB}/(1024*1024)={GB}
| <tr class="no-pre-registered"> | ||
| <td colspan="5"> | ||
| <p class="no-host-header">{{t common.noHostsFound}}</p> | ||
| <p style="font-size: 12px;">{{t installer.step2.noHostsFound.header}}</p> |
| var tempArr = []; | ||
| if (this.get('manualInstall')) { | ||
| var hostNames = this.get('manuallyInstalledHosts').mapProperty('hostName'); | ||
| tempArr.push(hostNames); |
There was a problem hiding this comment.
You are pushing the whole array instead hostname string, should be:
tempArr = this.get('manuallyInstalledHosts').mapProperty('hostName');
ishanbha
force-pushed
the
AMBARI-22826-branch-feature-AMBARI-14714-ui
branch
from
8dced85
to
2a02ac3
Compare
ishanbha
force-pushed
the
AMBARI-22826-branch-feature-AMBARI-14714-ui
branch
from
2a02ac3
to
c7e0620
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Ambari Web tests pass successfully. The failure is due to Ambari Server tests failing. |
Creating new pull request as the previous one was closed and branch deleted.
@atkach your suggestions are incorporated here
What changes were proposed in this pull request?
Add hosts step related changes for mpack
How was this patch tested?
20392 passing (23s)
125 pending
Please review Ambari Contributing Guide before opening a pull request.