Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-24441] [Log Search UI] The graphs are not always resized on window resize event. #2051

Merged
merged 1 commit into from Aug 14, 2018

Conversation

tobias-istvan
Copy link
Member

What changes were proposed in this pull request?

The throttleTime RXJS method was used to use in order to decrease the calls of the window resize and window scroll handlers.
But the right method from RXJS is the debounceTime since this will make sure that the handler will be called at least once when an event triggered.

All the previous wrong solution has been replaced by the debounceTime one.

How was this patch tested?

It was tested manually and by unit tests:

PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 268 of 268 SUCCESS (11.567 secs / 11.443 secs)
✨  Done in 47.47s.

Please review Ambari Contributing Guide before opening a pull request.

@asfgit
Copy link

asfgit commented Aug 14, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3576/
Test PASSed.

Copy link
Contributor

@aBabiichuk aBabiichuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing type definitions?

@tobias-istvan
Copy link
Member Author

The TypeScript will automatically set the type for those variables where a default value has been set. No need for explicit type definition.

@tobias-istvan tobias-istvan merged commit 04b738e into apache:trunk Aug 14, 2018
@tobias-istvan tobias-istvan deleted the AMBARI-24441-trunk branch August 14, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants