Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-24433] [Log Search UI] Reset to default selection in the drop… #2092

Merged

Conversation

tobias-istvan
Copy link
Member

What changes were proposed in this pull request?

  • default selection property has been added to dropdown list component: initialised on init or on the first onChanges when the default selection is empty
  • link to clear to default when it is enabled and has default selection

How was this patch tested?

It was tested manually and by unit tests:

PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 268 of 268 SUCCESS (8.679 secs / 8.57 secs)
✨  Done in 38.62s.

Please review Ambari Contributing Guide before opening a pull request.

@asfgit
Copy link

asfgit commented Aug 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3633/
Test FAILed.
Test FAILured.

@tobias-istvan
Copy link
Member Author

The test failure is not connected to the change.

@tobias-istvan tobias-istvan merged commit 276871b into apache:branch-2.7 Aug 16, 2018
@tobias-istvan tobias-istvan deleted the AMBARI-24433-branch-2.7 branch August 16, 2018 13:57
aBabiichuk pushed a commit to aBabiichuk/ambari that referenced this pull request Sep 25, 2018
…downs (apache#2092)

(cherry picked from commit f40586f)
(cherry picked from commit 276871b)

Change-Id: I6e3ae65d655fd7e9ace6a50d77c43c738dea0cb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants