[AMBARI-24580] [Log Search UI] Change the fix width and the height for the modal to flexible layout #2251
Conversation
… the modal to flexible layout
|
Refer to this link for build results (access rights to CI server needed): |
…r the modal to flexible layout - adding the missing licenses to the new files
|
Refer to this link for build results (access rights to CI server needed): |
|
The test failures have no connection with the changes. |
| <div *ngIf="showBackdrop" class="modal-backdrop" (click)="onBackdropClick($event)"></div> | ||
| <div class="modal-dialog" role="document"> | ||
| <div class="modal-content"> | ||
| <div class="modal-header"> |
There was a problem hiding this comment.
If there's neither title nor header content nor close button provided, there will be an empty area displayed (whis is the padding of empty modal-header). Don't think it's expected
| <div class="modal-body"> | ||
| <ng-content select="main"></ng-content> | ||
| </div> | ||
| <div class="modal-footer"> |
There was a problem hiding this comment.
I guess the same is relevant for footer as well
…r the modal to flexible layout
|
Refer to this link for build results (access rights to CI server needed): |
…r the modal to flexible layout (apache#2251) * [AMBARI-24580] [Log Search UI] Change the fix with and the height for the modal to flexible layout * [AMBARI-24580] [Log Search UI] Change the fix width and the height for the modal to flexible layout - adding the missing licenses to the new files * [AMBARI-24580] [Log Search UI] Change the fix width and the height for the modal to flexible layout
What changes were proposed in this pull request?
I created a new modal component named as ModalDialogComponent. I kept the ModalComponent still there because I want to change the current modals one by one.
The LogIndexFilter screen was the main reason why we did this change, so that is why I fixed its layout here by changing the Modal to ModalDialog, moving the cluster selection logic into the parent, using the sticky position to have a better UX (except IE 11).
Since I wanted to reuse the data loader icon here, I created a standalone component for this.
I found a typo in a component and I fixed this.
The huge number of files is mainly because the last two changes.
Note: There is a known issue: when you click on the
Filterbutton the first time it does not open, but it will when the filters params are already there. This bug is already fixed within AMBARI-23820 which is almost done.How was this patch tested?
It was tested heavily manually and by run the unit tests:
Please review Ambari Contributing Guide before opening a pull request.