Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-24716 : Restrict user permissions for Atlas configuration file. #2419

Merged

Conversation

vishalsuvagia
Copy link
Contributor

What changes were proposed in this pull request?

Need to restrict user permissions for Atlas configuration file.

How was this patch tested?

Tested by setting up a fresh cluster.

@asfgit
Copy link

asfgit commented Oct 3, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4153/
Test PASSed.

Copy link
Member

@jonathan-hurley jonathan-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of other stuff in this file is mode 644, so why is this the only one that needs to change?

Copy link
Member

@jonathan-hurley jonathan-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the reason for this appears to be that sensitive information can be stored in files like users-credentials.properties, so we should prevent world-readable for these.

@vishalsuvagia vishalsuvagia merged commit 041e268 into apache:branch-2.7 Oct 4, 2018
@vishalsuvagia
Copy link
Contributor Author

Thank-you @jonathan-hurley and @fimugdha for reviewing the patch.

kasakrisz pushed a commit to kasakrisz/ambari that referenced this pull request Oct 16, 2018
apache#2419)

(cherry picked from commit 041e268)

Change-Id: Ie87273e36ad4341792fc9c8277ab101f42b0f659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants