Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-24820] Set cloud storage tracking property for GCS #2510

Merged
merged 1 commit into from Oct 24, 2018

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Add a new property in core-site for tracking purposes on GCS.

https://issues.apache.org/jira/browse/AMBARI-24820

How was this patch tested?

Tested fresh install of HDP 2.6.4. Verified that core-site config contains the new property:

"fs.gs.application.name.suffix" : " (GPN:Hortonworks; version 1.0) HDP/{{version}}"

And so does /etc/hadoop/conf/core-site.xml:

<property>
  <name>fs.gs.application.name.suffix</name>
  <value> (GPN:Hortonworks; version 1.0) HDP/2.6.4.0-91</value>
</property>

Tested stack upgrade from HDP 2.5.6 to HDP 2.6.4. Verified that the new property is added to core-site during upgrade:

core-site/fs.gs.application.name.suffix changed to " (GPN:Hortonworks; version 1.0) HDP/{{version}}"

Change-Id: Ife0f7e0601cd7e662e995624997fed37fc38223a
@adoroszlai adoroszlai self-assigned this Oct 24, 2018
@asfgit
Copy link

asfgit commented Oct 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4383/
Test PASSed.

Copy link
Member

@jonathan-hurley jonathan-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few questions, but the changes look fine.

@@ -398,6 +398,7 @@
<definition xsi:type="configure" id="hdfs_user_agent" summary="Set User-Agent">
<type>core-site</type>
<set key="fs.azure.user.agent.prefix" value="User-Agent: APN/1.0 Hortonworks/1.0 HDP/{{version}}" if-type="core-site" if-key="fs.azure.user.agent.prefix" if-key-state="absent" />
<set key="fs.gs.application.name.suffix" value=" (GPN:Hortonworks; version 1.0) HDP/{{version}}" if-type="core-site" if-key="fs.gs.application.name.suffix" if-key-state="absent" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even support these ancient versions of HDP on Ambari 2.7? I thought that we only supported HDP 2.6+ ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted the new property to be consistent with the related S3 and Azure properties.

I don't know if these versions are officially supported. I tested with 2.5 -> 2.6 upgrade, and both install and upgrade worked fine.

@adoroszlai adoroszlai merged commit e243d05 into apache:branch-2.7 Oct 24, 2018
@adoroszlai adoroszlai deleted the AMBARI-24820_branch-2.7 branch October 24, 2018 23:04
mpapirkovskyy pushed a commit to mpapirkovskyy/ambari that referenced this pull request Jul 15, 2019
(cherry picked from commit e243d05)

Change-Id: I23477e3b96e1c54596c762e66e0a5a541a4b6e72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants