New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMBARI-24907. Updated service metainfo to declare LDAP integration support #2621
Conversation
Refer to this link for build results (access rights to CI server needed): |
LGTM wtr the checkstyle fix. |
Refer to this link for build results (access rights to CI server needed): |
@@ -226,6 +231,9 @@ | |||
"Automated SSO integration will not be allowed for this service.", | |||
serviceName); | |||
} | |||
|
|||
ldapIntegrationSupported = sInfo.isLdapSupported(); | |||
ldapEnabledTest = StringUtils.isNotBlank(sInfo.getLdapEnabledTest()) ? PredicateUtils.fromJSON(sInfo.getLdapEnabledTest()) : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for code reuse, make compileKerberosEnabledPredicate
generic?
private Predicate compilePredicate(String json) {
if (StringUtils.isNotBlank(json)) {
return PredicateUtils.fromJSON(json);
}
return null;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops.. already merged... :|
What changes were proposed in this pull request?
Update service metainfo to declare LDAP integration support. The following tag may be optionally set in a service's metainfo.xml file:
How was this patch tested?
Executing JUnit tests in
ambari-server
:In addition to unit testing the following E2E tests have been done locally:
metainfo.xml
and added the aboveldap
XML elements4.1. authentication method was set to
UNIX
(the default one):4.2. updated Ranger's authentication method to
LDAP
:<ldap>
setting here):