Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25018. End users should be able to execute setup-ldap tool without manual intervention #2706

Merged
merged 2 commits into from Dec 10, 2018

Conversation

smolnar82
Copy link
Contributor

@smolnar82 smolnar82 commented Dec 10, 2018

What changes were proposed in this pull request?

We should provide a way to our end user to execute ambari-server setup-ldap in a non-interactive way (i.e. all answers are provided by command line options).

This was not the case when we wanted to setup a secure LDAP (SSL is set to true) but we did not want to use a custom trust store. In this case the following question(s) were being asked:

  1. Do you want to provide custom TrustStore for Ambari?
  2. Optionally: if custom trust store was set previously the tool displays the earlier configuration and asks the following: Do you want to remove these properties?

To address this issue I modified the tool to find out whether it's being executed in non-interactive mode or not. Non-interactive mode, in this respect, means that all properties which require a non-empty answer have their answers provided via CLI options.

How was this patch tested?

In addition to running unit tests I've executed several E2E tests within my vagrant environment; see test results in this file: setup_ldap_in_ambari_2.7.100.0-171.txt

@asfgit
Copy link

asfgit commented Dec 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4716/
Test FAILed.
Test FAILured.

Copy link
Contributor

@kasakrisz kasakrisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit
Copy link

asfgit commented Dec 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4717/
Test PASSed.

@smolnar82 smolnar82 merged commit 38b2e50 into apache:trunk Dec 10, 2018
@smolnar82 smolnar82 deleted the AMBARI-25018 branch December 10, 2018 15:25
vishalsuvagia pushed a commit to vishalsuvagia/ambari that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants