Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-25184] configs.py: cannot set an empty property value #2911

Closed
wants to merge 8 commits into from

Conversation

apappu
Copy link
Contributor

@apappu apappu commented Apr 3, 2019

What changes were proposed in this pull request?

Made a change to allow empty value for any key
(Please fill in changes proposed in this fix)

How was this patch tested?

Tested the patch in live ambari server to update the configs.

  1. Tried running configs.py to update empty value for key value.
  2. Tried running configs.py to update with actual value.
  3. Tried running configs.py to update the config with input from file

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review [Ambari Contributing Guide]
(https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.

@apappu apappu closed this Apr 3, 2019
@apappu apappu deleted the AMBARI-25184 branch April 3, 2019 23:52
@asfgit
Copy link

asfgit commented Apr 3, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5098/
Test FAILed.
Test FAILured.

@rlevas rlevas changed the title Ambari 25184 [AMBARI-25184] configs.py: cannot set an empty property value Apr 4, 2019
@asfgit
Copy link

asfgit commented Apr 4, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5101/
Test FAILed.
Test FAILured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants