AMBARI-25483 Web alert triggers a wrong critical alert in kerberized cluster #3181
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python use function time.time() get current time the unit is second, but we need millisecond here.
|
@xihuanbanku please file an Apache jira ticket and use it in the commit msg |
hapylestat
changed the title
hapylestat
suggested changes
Jul 24, 2020
| @@ -124,7 +124,7 @@ def curl_krb_request(tmp_dir, keytab, principal, url, cache_file_prefix, | |||
| # kinit if it's time; this helps to avoid problems approaching ticket boundary when | |||
| # executing a klist and then a curl | |||
| last_kinit_time = _KINIT_CACHE_TIMES.get(ccache_file_name, 0) | |||
| current_time = long(time.time()) | |||
| current_time = long(time.time() * 1000) | |||
There was a problem hiding this comment.
lets define a function in the code like:
def get _current_time_ms():
return round(time.time() * 1000)
and then use it instead any occurrence of time.time() in the module ?
|
The change suggestion is ok, it seems that comments assume that Any usage of the mentioned function should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python use function time.time() get current time the unit is second, but we need a millisecond here.
What changes were proposed in this pull request?
When a kerberized "WEB" type alert checks its status with kinit for the very first time. It will create a cache file with command "kinit -c /path/to/tmp/cache -kt /path/to/keytab/file some-principal", next time the alert executes, it will check the cache file status first, which checks the difference between current timestamp and last kinit timestamp. But when compare these two timestamps, we should use "millisecond" unit, not "second". From the variable name of kinit_timer_ms we also could firgure is out. Otherwise, the "if" statement at line 128 will never return True after 14400000 seconds(166.66 days) later.
How was this patch tested?
manual tests