Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25545 Downloaded zip-file name shows empty in the fileview (akiyamaneko) (#3220) #3220

Merged
merged 3 commits into from Sep 29, 2020

Conversation

echohlne
Copy link

@echohlne echohlne commented Aug 15, 2020

fix downloaded zip-file name shows empty in the fileview

https://issues.apache.org/jira/browse/AMBARI-25545

How was this patch tested?

manual tests

the problem is below:

question-screenshot

after modify the result like below:
question-fixed-screenshot

If the file or directory name in HDFS contains non-ASCII characters, the name of zip file generated by downloading will be displayed incorrectly
@echohlne echohlne changed the title AMBARI-25545 AMBARI-25545 file view non-ascii name download bug fixed. Aug 15, 2020
If the file or directory name in HDFS contains non-ASCII characters, the name of zip file generated by downloading will be displayed incorrectly
If the file or directory name in HDFS contains non-ASCII characters, the name of zip file generated by downloading will be displayed incorrectly
@echohlne echohlne changed the title AMBARI-25545 file view non-ascii name download bug fixed. AMBARI-25545 If the file or directory name in HDFS contains non-ASCII characters, the name of zip file generated by downloading will be displayed incorrectly Aug 16, 2020
@echohlne echohlne changed the title AMBARI-25545 If the file or directory name in HDFS contains non-ASCII characters, the name of zip file generated by downloading will be displayed incorrectly AMBARI-25545 fix downloaded zip-file name shows empty in the fileview page. Aug 26, 2020
@echohlne echohlne changed the title AMBARI-25545 fix downloaded zip-file name shows empty in the fileview page. AMBARI-25545 fix downloaded zip-file name shows empty in the fileview. Aug 26, 2020
@hapylestat hapylestat added the server Ambari server label Sep 28, 2020
@hapylestat hapylestat self-requested a review September 29, 2020 10:53
Copy link
Contributor

@hapylestat hapylestat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contribution

@hapylestat hapylestat merged commit c0bef35 into apache:branch-2.7 Sep 29, 2020
@hapylestat hapylestat changed the title AMBARI-25545 fix downloaded zip-file name shows empty in the fileview. AMBARI-25545 Downloaded zip-file name shows empty in the fileview (akiyamaneko) (#3220) Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Ambari server
Projects
None yet
2 participants