Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25546 To prevent negative float and NaN value in heatmap metrics page. #3223

Merged
merged 1 commit into from Sep 29, 2020
Merged

Conversation

echohlne
Copy link

@echohlne echohlne commented Aug 26, 2020

The jira is : https://issues.apache.org/jira/browse/AMBARI-25546

To prevent negative float and NaN value in heatmap metrics page.
we test it like below:

How was this patch tested?

manual tests

before modify:
heatmap-negative-screentshot.png
heatmap--metrics-NaN-screentshot.png

after modify
heatmap-metrics-negative-fixed-screenshot.png
heatmap--metrics-NaN-fixed-screentshot.png

To prevent negative float and NaN value in heatmap metrics page.
@echohlne echohlne changed the title AMBARI-25546 AMBARI-25546 To prevent negative float and NaN value in heatmap metrics page. Aug 26, 2020
@hapylestat hapylestat added the web client Ambari WebUI Client label Sep 28, 2020
@hapylestat hapylestat requested review from atkach, hapylestat and a user September 29, 2020 10:56
Copy link
Contributor

@hapylestat hapylestat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web client Ambari WebUI Client
Projects
None yet
2 participants