Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25563. Storm dashboards are not showing metrics. #3255

Merged
merged 2 commits into from Nov 9, 2020

Conversation

dvitiiuk
Copy link

@dvitiiuk dvitiiuk commented Nov 5, 2020

What changes were proposed in this pull request?

The problem was in interpretation of Null for BINARY fields during working via phoenix with hbase. Null value was being wrote as array of zero bytes, so after reading of this value we got not Null, but array of zero bytes. Now array of zero bytes is being interpreted as Null. Also as result we shouldn't generate UUIDs which contain only zero bytes.

Also made some fixes in ambari datasource.js for grafana.

How was this patch tested?

Manual test:

  • created kafka-based and usual storm topologies and checked that all appropriate metrics are being displayed.
  • run metrics tests locally.

@dvitiiuk
Copy link
Author

dvitiiuk commented Nov 5, 2020

@payert @hapylestat @pidhaietsdp Could you please review this?

@pidhaietsdp
Copy link

@dvitiiuk Looks fine for me.

@payert payert self-requested a review November 9, 2020 09:41
Copy link

@payert payert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hapylestat hapylestat merged commit 5fd2325 into apache:branch-2.7 Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants