AMBARI-25719. Fail to enable kerberos due to NullPointerException and HostNotFoundException #3354
Conversation
… HostNotFoundException - make a log on threads, propagate Exception and don't ignore it silently
|
@eubnara any chance to keep the test report ..? |
| } catch (NumberFormatException|AmbariException ignored) {} | ||
| } catch (NumberFormatException|AmbariException e) { | ||
| LOG.error("Exception on sendAgentCommand", e); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
this should be incomtablie change right as it was ignore before. and actionschduler throws only ambariexception.
There was a problem hiding this comment.
Could I change RuntimeException to AmbariException ?
If I don't rethrow the exception, it hangs on Test Kerberos Client or Distribute Keytabs and you would wait until it gets timeout.
There was a problem hiding this comment.
Let's through AmbariException.
There was a problem hiding this comment.
I think RuntimeException or AmbariRuntimeException will be handled on ActionScheduler#run. (https://github.com/apache/ambari/blob/branch-2.7/ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java#L352-L354)
So, I just changed RuntimeException to AmbariRuntimeException.
If you want to use AmbariException, many changes are needed.
Isn't it the right way to use AmbariRuntimeException instead of AmbariException?
There was a problem hiding this comment.
There is also another example line which use AmbariRuntimeException when a step fails in the middle of a stage.
=> https://github.com/apache/ambari/blob/branch-2.7/ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AgentCommandsPublisher.java#L178
There was a problem hiding this comment.
ok.. I also feel, AmbariRuntimeException should be fine.
| } catch (NumberFormatException|AmbariException ignored) {} | ||
| } catch (NumberFormatException|AmbariException e) { | ||
| LOG.error("Exception on sendAgentCommand", e); | ||
| throw new AmbariRuntimeException(e); |
There was a problem hiding this comment.
Oh, wait please.
When installing new cluster, NumberFormatException raises because there is no cluster id for new cluster yet on line clusterId = Long.valueOf(((ExecutionCommand)ac).getClusterId());.
It hangs and cannot proceed next stages.
I'll fix it wait please.
2022-09-02 07:55:34,472 ERROR [agent-command-publisher-1] AgentCommandsPublisher:115 - Exception on sendAgentCommand
java.lang.NumberFormatException: null
at java.lang.Long.parseLong(Long.java:552)
at java.lang.Long.valueOf(Long.java:803)
at org.apache.ambari.server.events.publishers.AgentCommandsPublisher.lambda$null$0(AgentCommandsPublisher.java:110)
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at com.google.common.collect.CollectSpliterators$1.lambda$forEachRemaining$1(CollectSpliterators.java:116)
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)
at com.google.common.collect.CollectSpliterators$1.forEachRemaining(CollectSpliterators.java:116)
at com.google.common.collect.CollectSpliterators$1FlatMapSpliterator.lambda$forEachRemaining$1(CollectSpliterators.java:247)
at java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1723)
at com.google.common.collect.CollectSpliterators$1FlatMapSpliterator.forEachRemaining(CollectSpliterators.java:247)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:401)
at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:734)
at java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:650)
at org.apache.ambari.server.events.publishers.AgentCommandsPublisher.lambda$sendAgentCommand$1(AgentCommandsPublisher.java:103)
at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
There was a problem hiding this comment.
@brahmareddybattula
Hmm... Is it better not to rethrow? Just logging?
There was a problem hiding this comment.
yes, just logging should be fine, we just need to avoid the hung right.
eubnara
force-pushed
the
AMBARI-25719-branch-2.7
branch
from
2730b62
to
9111e06
Compare
|
I have created a new PR to clean up commit logs. => #3361 |
I missed one logging on thread. I add it.
This PR follows #3344 (comment).