AMBARI-25754 :: Ambari server.compilation failing due to unused imports #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs password change.
… in host details page (sjanardhanhw via ababiichuk)
… select any item (apache#2599) Change-Id: I9ef62c6e77e3d89d6548734793dc246a7342e80e
…erberos with MIT KDC using a new variable replacement function (apache#2788)
… maintenance mode (apache#2787)
…d knox proxy (amagyar) (apache#2775) (apache#2799)
… dot in their username.
… all hosts where they are needed (apache#2802)
…ss to any group and just have access to Filesview
…VERE TypeError: widgetGroups is undefined"
…ache#2819) * AMBARI-25151 SystemD support for ambari-agent on SLES12 (benyoka) * AMBARI-25151 fix service unit file (benyoka) * AMBARI-25151 fix service unit file (benyoka) * AMBARI-25151 review comment (benyoka) * AMBARI-25151 remove runlevel 2 and 4 (benyoka) * AMBARI-25151 add pidfile, disable RemainAfterExit (benyoka)
…ect in 2.7.x. (mpapirkovskyy) (apache#2825)
…on of STOMPUpdatePublisher. (mpapirkovskyy) (apache#2826)
…pache#2646) (apache#2829) * AMBARI-24938 quick link profiles can override link url (benyoka) * AMBARI-24938 new unit test in QuickLinkArtifactResourceProviderTest (benyoka) * AMBARI-24938 review findings + check style issue + unit test fix (benyoka)
…ect in 2.7.x. (mpapirkovskyy) (apache#2832)
* origin/branch-2.7: (28 commits) AMBARI-25159. http.strict-transport-security change does not take affect in 2.7.x. (mpapirkovskyy) (apache#2832) [AMBARI-24938] quick link profiles can override link url (benyoka) (apache#2646) (apache#2829) AMBARI-25164 Rack "Config Refresh" behaviour is different in Ambari 2.6 and 2.7.3 AMBARI-25063. Restarting Ambari Server Fails Due to Recursive Injection of STOMPUpdatePublisher. (mpapirkovskyy) (apache#2826) AMBARI-25159. http.strict-transport-security change does not take affect in 2.7.x. (mpapirkovskyy) (apache#2825) AMBARI-25151 SystemD support for ambari-agent on SLES12 (benyoka) (apache#2819) AMBARI-25158 Dashboard is unable to load . Common console error : "SEVERE TypeError: widgetGroups is undefined" AMBARI-25123. /var/lib/ambari-agent/cache not updating (Ambari 2.7) (aonishuk) AMBARI-24885 Ambari Files view not working when User doesnt have access to any group and just have access to Filesview AMBARI-25141. Encrypting LDAP manager password in case password security is ON (apache#2810) AMBARI-25055 JS error after starting stack downgrade AMBARI-24672. Make sure we regenerate all service specific keytabs on all hosts where they are needed (apache#2802) AMBARI-25052 Unable to Add Services Due to toMapByProperty() AMBARI-25102 Dasboard metrics will not load for ambari user which has dot in their username. AMBARI-25117. getAsPost requests don't work when ambari is used behind knox proxy (amagyar) (apache#2775) (apache#2799) AMBARI-24986. Using Ambari server's CLI to enable/disable Trusted Proxy support (apache#2798) AMBARI-25090 - Logsearch should index keywords without the ending periods(.) (apache#2791) AMBARI-25114. Log Search: SSL props needs to be set if only ambari-server uses SSL (apache#2792) AMBARI-25041. Scale hosts does not install component if service is in maintenance mode (apache#2787) AMBARI-24847 - Logsearch: Cannot search for a term that includes spaces or dashes (apache#2790) ...
Issue: Ambari server build is failing due to checkstyles reporting for unused imports. Changes: Removed unused imports.
|
@vishalsuvagia thanks for quick patch.. Patch lgtm.. Can you rebase the PR..? |
|
The PR can merge without conflicts. Does it still need to rebase? |
|
@jojochuang thanks for pitching here. There are 31 commits in the commit message (there are no code conflicts), I want to aviod those to make to clear purpose. |
|
'Sqaush and merge' will merge them all into one commit. |
vishalsuvagia
requested review from
brahmareddybattula,
jojochuang,
kevinw66 and
virajjasani
|
@brahmareddybattula, @virajjasani, @jojochuang, @kevinw66 request to kingly review the fix |
|
@brahmareddybattula, @virajjasani Thank-you for reviewing the patch. |
brahmareddybattula
pushed a commit
to brahmareddybattula/ambari
that referenced
this pull request
Dec 11, 2022
…ts (apache#3389) * AMBARI-24886 : Add stack feature constant to support Ranger admin users password change. * AMBARI-24603 Better scrolling for long list of components in dropdown in host details page (sjanardhanhw via ababiichuk) * AMBARI-24572 Fixing the cluster name alignment (sjanardhanhw via ababiichuk) * [AMBARI-24887] [Log Search UI] The component filter dropdown does not select any item (apache#2599) Change-Id: I9ef62c6e77e3d89d6548734793dc246a7342e80e * AMBARI-24874 : Storm Service Check fail with 'The TGT found is not renewable' (apache#2638) * AMBARI-24970 Set Hive pre-upgrade threshold for using Hive 1 jars to 3.1 * AMBARI-24979 Redirect Hive Pre-upgrade log to a logfile * AMBARI-24879. kAdmin principal name is set on the GUI when enabling Kerberos with MIT KDC using a new variable replacement function (apache#2788) * AMBARI-24847 - Logsearch: Cannot search for a term that includes spaces or dashes (apache#2790) * AMBARI-25041. Scale hosts does not install component if service is in maintenance mode (apache#2787) * AMBARI-25114. Log Search: SSL props needs to be set if only ambari-server uses SSL (apache#2792) * AMBARI-25090 - Logsearch should index keywords without the ending periods(.) (apache#2791) * AMBARI-24986. Using Ambari server's CLI to enable/disable Trusted Proxy support (apache#2798) * AMBARI-25117. getAsPost requests don't work when ambari is used behind knox proxy (amagyar) (apache#2775) (apache#2799) * AMBARI-25102 Dasboard metrics will not load for ambari user which has dot in their username. * AMBARI-25052 Unable to Add Services Due to toMapByProperty() * AMBARI-24672. Make sure we regenerate all service specific keytabs on all hosts where they are needed (apache#2802) * AMBARI-25055 JS error after starting stack downgrade * AMBARI-25141. Encrypting LDAP manager password in case password security is ON (apache#2810) * AMBARI-24885 Ambari Files view not working when User doesnt have access to any group and just have access to Filesview * AMBARI-25123. /var/lib/ambari-agent/cache not updating (Ambari 2.7) (aonishuk) * AMBARI-25158 Dashboard is unable to load . Common console error : "SEVERE TypeError: widgetGroups is undefined" * AMBARI-25151 SystemD support for ambari-agent on SLES12 (benyoka) (apache#2819) * AMBARI-25151 SystemD support for ambari-agent on SLES12 (benyoka) * AMBARI-25151 fix service unit file (benyoka) * AMBARI-25151 fix service unit file (benyoka) * AMBARI-25151 review comment (benyoka) * AMBARI-25151 remove runlevel 2 and 4 (benyoka) * AMBARI-25151 add pidfile, disable RemainAfterExit (benyoka) * AMBARI-25159. http.strict-transport-security change does not take affect in 2.7.x. (mpapirkovskyy) (apache#2825) * AMBARI-25063. Restarting Ambari Server Fails Due to Recursive Injection of STOMPUpdatePublisher. (mpapirkovskyy) (apache#2826) * AMBARI-25164 Rack "Config Refresh" behaviour is different in Ambari 2.6 and 2.7.3 * [AMBARI-24938] quick link profiles can override link url (benyoka) (apache#2646) (apache#2829) * AMBARI-24938 quick link profiles can override link url (benyoka) * AMBARI-24938 new unit test in QuickLinkArtifactResourceProviderTest (benyoka) * AMBARI-24938 review findings + check style issue + unit test fix (benyoka) * AMBARI-25159. http.strict-transport-security change does not take affect in 2.7.x. (mpapirkovskyy) (apache#2832) * AMBARI-25754 : Ambari server build is failing due to checkstyle issues Issue: Ambari server build is failing due to checkstyles reporting for unused imports. Changes: Removed unused imports. Co-authored-by: Vishal Suvagia <vishalsuvagia@apache.org> Co-authored-by: sjanardhanhw <sjanardhan@hortonworks.com> Co-authored-by: Istvan Tobias <tobias.istvan@gmail.com> Co-authored-by: Rajkumar Singh <rajkrrsingh@gmail.com> Co-authored-by: Miklos Gergely <mgergely@hortonworks.com> Co-authored-by: Sandor Molnar <smolnar@apache.org> Co-authored-by: kasakrisz <33458261+kasakrisz@users.noreply.github.com> Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com> Co-authored-by: Olivér Sz <oleewere@gmail.com> Co-authored-by: Attila Magyar <m.magyar3@gmail.com> Co-authored-by: Andrii Tkach <atkach@apache.org> Co-authored-by: Akhil Subhash Naik <asnaik@hortonworks.com> Co-authored-by: Andrew Onishuk <aonishuk@hortonworks.com> Co-authored-by: benyoka <benyoka@users.noreply.github.com> Co-authored-by: Myroslav Papirkovskyi <mpapirkovskyy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unused imports
How was this patch tested?
ambari-server compilation succeeded after removing unused imports.