Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25956: [ Rolling upgrade] Hive Server Going down after upgrade #3713

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

dmmkr
Copy link
Contributor

@dmmkr dmmkr commented Jun 23, 2023

What changes were proposed in this pull request?

Fix Source version in hive_server_upgrade.py
(Please fill in changes proposed in this fix)

How was this patch tested?

Verified the flow in express upgrade and rollback, deregister is happening with the expected versions.

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@virajjasani
Copy link
Contributor

Is the build failure relevant?

----------------------------------------------------------------------
Failed tests:
FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/jenkins-agent/workspace/bari-PreCommit-GitHub-PR_PR-3713/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
    return func(*args, **keywargs)
  File "/home/jenkins/jenkins-agent/workspace/bari-PreCommit-GitHub-PR_PR-3713/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 859, in test_stop_during_upgrade
    tries=1, user='hive')
  File "/home/jenkins/jenkins-agent/workspace/bari-PreCommit-GitHub-PR_PR-3713/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 326, in assertResourceCalledIgnoreEarlier
    self.assertNotEqual(len(RMFTestCase.env.resource_list), 0, "The specified resource was not found in the call stack.")
AssertionError: The specified resource was not found in the call stack.

FAIL: test_stop_during_upgrade_with_default_conf_server (test_hive_server.TestHiveServer)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/jenkins-agent/workspace/bari-PreCommit-GitHub-PR_PR-3713/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
    return func(*args, **keywargs)
  File "/home/jenkins/jenkins-agent/workspace/bari-PreCommit-GitHub-PR_PR-3713/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 892, in test_stop_during_upgrade_with_default_conf_server
    tries=1, user='hive')
  File "/home/jenkins/jenkins-agent/workspace/bari-PreCommit-GitHub-PR_PR-3713/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 326, in assertResourceCalledIgnoreEarlier
    self.assertNotEqual(len(RMFTestCase.env.resource_list), 0, "The specified resource was not found in the call stack.")
AssertionError: The specified resource was not found in the call stack.

----------------------------------------------------------------------
Total run:1220
Total errors:0
Total failures:2
ERROR
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation

@dmmkr
Copy link
Contributor Author

dmmkr commented Aug 6, 2023

@virajjasani Fixed the test case failure

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani merged commit e1becd5 into apache:branch-2.7 Aug 6, 2023
1 check passed
@virajjasani
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants