[AMBARI-22649] settings library should convert true/false to boolean #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
settings
library for gettingclusterSettings
andstackSettings
should convert literal"true"
and"false"
values to the Python boolean type to retain backward compatibility withConfigDictionary
:ambari/ambari-common/src/main/python/resource_management/libraries/script/config_dictionary.py
Lines 57 to 62 in 40e5585
Stack scripts rely on this behavior in a lot of places. One of the most widely used is the
security_enabled
flag. Without this conversion, scripts would execute the "secure" code path for both"true"
and"false"
values, since only the empty string is treated asFalse
.ambari/ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_linux.py
Line 96 in 40e5585
ambari/ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper.py
Line 99 in 40e5585
How was this patch tested?
Deployed cluster using blueprint.
Unit test tweaked, passing: