AMBARI-22781. Fix OneFS blueprint installation (amagyar) #485
Conversation
| } | ||
|
|
||
| @Test | ||
| public void testHasHadoopCompatibleFsWhenThereIsNoHCFS() throws Exception { |
There was a problem hiding this comment.
I guess this should be testDoesNotHave...
| @@ -1542,6 +1542,10 @@ public String updateForClusterCreate(String propertyName, | |||
| return origValue; | |||
| } | |||
|
|
|||
| if (topology.hasHadoopCompatibleFileSystem()) { | |||
| return origValue; | |||
There was a problem hiding this comment.
I think this condition should also include a check that the component being processed is one from OneFS. Otherwise it will fail to throw IllegalArgumentException for other components when it should.
To verify this, make the following change in BlueprintConfigurationProcessorTest and run it:
@@ -8244,7 +8244,11 @@ public class BlueprintConfigurationProcessorTest extends EasyMockSupport {
replay(bp, topologyRequestMock);
- ClusterTopology topology = new ClusterTopologyImpl(ambariContext, topologyRequestMock);
+ ClusterTopology topology = new ClusterTopologyImpl(ambariContext, topologyRequestMock) {
+ public boolean hasHadoopCompatibleFileSystem() {
+ return true;
+ }
+ };
topology.setConfigRecommendationStrategy(ConfigRecommendationStrategy.NEVER_APPLY);
return topology;Result:
[ERROR] BlueprintConfigurationProcessorTest.testDoUpdateForClusterCreate_SingleHostProperty__MissingComponent:2344 IllegalArgumentException should have been thrown
[ERROR] BlueprintConfigurationProcessorTest.testDoUpdateForClusterCreate_SingleHostProperty__MultipleMatchingHostGroupsError:2386 IllegalArgumentException should have been thrown
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -259,6 +261,14 @@ public ComponentInfo getComponentInfo(String component) { | |||
| return componentInfo; | |||
| } | |||
|
|
|||
| public Optional<ServiceInfo> getServiceInfo(String serviceName) { | |||
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
What changes were proposed in this pull request?
OneFS blueprint installation failed because SingleHostTopologyUpdater tried to determine the namenode host which doesn't exist in a onefs setup.
How was this patch tested?
I used the following minimal blueprint to create a cluster with OneFS.
{ "configurations": [ { "onefs": { "properties": { "onefs_host": "scisilon.fqdn" } } } ], "host_groups": [{ "name": "host_group_1", "components": [ { "name": "ZOOKEEPER_SERVER" }, { "name": "ZOOKEEPER_CLIENT" }, { "name": "ONEFS_CLIENT" } ], "cardinality": "1" }], "Blueprints": { "stack_name": "HDP", "stack_version": "2.6" } }