New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMBARI-23276] Maven cleanup #699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to this link for build results (access rights to CI server needed): |
@smolnar82 please review. |
rlevas
approved these changes
Mar 18, 2018
@@ -23,9 +23,9 @@ | |||
import org.apache.ambari.server.configuration.LdapUsernameCollisionHandlingBehavior; | |||
import org.apache.ambari.server.security.authorization.LdapServerProperties; | |||
import org.apache.ambari.server.utils.PasswordUtils; | |||
import org.apache.commons.lang.StringUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
benyoka
approved these changes
Mar 19, 2018
smolnar82
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up
pom.xml
files somewhat:version
and some other files in theprocess-resources
lifecycle phase, not ingenerate-resources
orgenerate-test-resources
.ambari-agent
andambari-server
that are already (or should be) declared in the parent POM.ambari-funtest
: itspom.xml
was copied fromambari-server
, but it really depends only on some libraries andambari-server
. There is nosrc/main/resources
inambari-funtest
, either.ambari-server
.ambari-serviceadvisor -> maven-assembly-plugin
. This brought a bunch of unnecessary jars toambari-server
's bundle:How was this patch tested?
ambari-server
andambari-agent
, installed locally. Verified that the jars listed above are not present in/usr/lib/ambari-server
.ambari-serviceadvisor
with inputs from a previous run: