[AMBARI-23397] Blueprint deployments for NameNode Federation Fail #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benyoka
approved these changes
Mar 29, 2018
|
Refer to this link for build results (access rights to CI server needed): |
adoroszlai
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implemented minor changes to the Blueprint processing code in order to support HDFS NameNode Federation deployments. Originally, HDFS NameNode HA deployments could only consist of two NameNodes per cluster, but the new Ambari 2.7.0 support for HDFS NameNode Federation will change that restriction, and now more than two NameNode instances will be supported in a given HDFS deployment in Ambari.
Some configuration processing code was updated to account for this change, and a new unit test was added to verify the change in the BlueprintConfigurationProcessor.
How was this patch tested?
Tested manually against a 3-node vagrant cluster, to ensure that deploying a cluster with three "NAMENODE" components does not cause any deployment error to be returned from the Blueprint deployment code.
Ran the full ambari-server unit test suite, with all Java and Python tests passing.
Deployed an HDFS NameNode HA cluster with Blueprints, using the older model of two NameNode instances in the cluster (Active/Standby), and verified that the HDFS deployment still succeeds with these new changes in place.
Please review Ambari Contributing Guide before opening a pull request.