[AMBARI-22725] Expose Conditional Elements For Tasks on Upgrade

[jonathan-hurley]

What changes were proposed in this pull request?

I decided to break out the work of having condition tasks with upgrading Kerberos-related properties (see AMBARI-22803 for the RPC/Kerberos related work)

Some upgrade tasks, such as configuration tasks, need to leverage the conditional elements which change the flow of control if the cluster is Kerberized (or based on other configuration values). For example, today we have this:

<execute-stage service="RANGER_KMS" component="RANGER_KMS_SERVER" title="Calculating Proxy Properties under kms-site">
  <condition xsi:type="security" type="kerberos"/>
  <task xsi:type="server_action" class="org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfig"/>
</execute-stage>

 

Where condition elements can be added to an execute-stage or a group. However, since execute-stage may only contain one task, it makes doing this work on a per-task level impossible. This particularly impacts the processing element. We want something like this:

<task xsi:type="configure" id="hdp_2_6_hadoop_rpc_protection">
  <condition xsi:type="security" type="kerberos"/>
</task>

 
So that task elements defined in the pre-upgrade section of processing can also be conditionally invoked.

How was this patch tested?

[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:52 min
[INFO] Finished at: 2018-01-17T14:12:56-05:00
[INFO] Final Memory: 69M/783M
[INFO] ------------------------------------------------------------------------

[jonathan-hurley]

One thing that bothers me is that this seems to only work with secure ports below 1024 - I think it should work on all ports. Checking with HDFS to see what the deal is there ...

[jonathan-hurley]

I decided to split out the RPC/Kerberos work into its own Jira since there seems to be some issue with HDFS with these changes: https://issues.apache.org/jira/browse/AMBARI-22803

[jonathan-hurley]

retest this please

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/172/
Test PASSed.