Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-23524] There is no alert for logfeeder #955

Closed
wants to merge 3 commits into from
Closed

[AMBARI-23524] There is no alert for logfeeder #955

wants to merge 3 commits into from

Conversation

AliceXiaoLu
Copy link

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

AliceXiaoLu and others added 2 commits February 2, 2018 10:06
zk started failed because core-site is not found
@asfgit
Copy link

asfgit commented Apr 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1746/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Apr 12, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1807/
Test FAILed.
Test FAILured.

@oleewere
Copy link
Contributor

oleewere commented May 17, 2018

hi @AliceXiaoLu ,
thank you for the contribution:
I have few points here:

  • you do not need to include the patch file as well
  • AMBARI-22894 is already fixed on trunk, so that changes probably not needed (probably you should rebase your branch)
  • windows support is not required

@oleewere oleewere changed the title There is no alerts for logfeeds [AMBARI-23524] There is no alert for logfeeder May 17, 2018
@AliceXiaoLu
Copy link
Author

@oleewere
ok,thank you.

@AliceXiaoLu
Copy link
Author

@oleewere
ok,thank you . I will follow your advisor

@oleewere
Copy link
Contributor

@AliceXiaoLu thanks for the contribution, i will close this (see #1564) - that will be in 2.7.0 release

@oleewere oleewere closed this Jun 17, 2018
Copy link
Contributor

@oleewere oleewere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants