[AMBARI-23531]. Debian9: Atlas client installation failed due to unsupported OS family error (amagyar)

[zeroflag]

What changes were proposed in this pull request?

Package installation on debian failed "Not able to create Repository Manager object for unsupported OS family" error.

How was this patch tested?

Installed HDP on debian.

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1751/
Test FAILed.
Test FAILured.

[hapylestat]

it's strange, i have supposed that DEBIAN is a child of the UBUNTU family, as it extends it. Problem will repeat with *-PPC variation of the system families. Could we extend OsFamily to return the root os family, not the extended leaf and use it in the constructor?

[zeroflag]

@hapylestat, I don't fully understand what you suggest.

The problem is that OSConst.UBUNTU_FAMILY is a simple string so it won't match to OSConst.DEBIAN_FAMILY.

>>> type(os_check.OSConst.OS_UBUNTU)
<type 'str'>

However this one works correctly and returns True on Debian.

>>> os_check.OSCheck.is_ubuntu_family()
True

So instead of the map lookup we could modify it to something like this:

  @classmethod
  def get_new_instance(cls, os_family=None):
    """
    Construct new instance of Repository Manager object. Call is not thread-safe

    :param os_family:  os family string; best used in combination with `OSCheck.get_os_family()`
    :type os_family str
    :rtype GenericManager
    """
    if not os_family:
      os_family = OSCheck.get_os_family()

    if OSCheck.is_in_family(os_family, OSConst.UBUNTU_FAMILY):
      return AptManager()
    if OSCheck.is_in_family(os_family, OSConst.SUSE_FAMILY):
      return ZypperManager()
    if OSCheck.is_in_family(os_family, OSConst.REDHAT_FAMILY):
      return YumManager()
    if OSCheck.is_in_family(os_family, OSConst.WINSRV_FAMILY):
      return ChocoManager()

    raise RuntimeError("Not able to create Repository Manager object for unsupported OS family {0}".format(os_family))```

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1765/
Test PASSed.