Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-23514-trunk] - Log Search UI: various fixes for History feature #962

Merged
merged 4 commits into from Apr 12, 2018

Conversation

tobias-istvan
Copy link
Member

What changes were proposed in this pull request?

  1. Implement handling of case when there's nothing to undo or redo
  2. Refine styles and labels for History dropdown
  3. Handle case of large history dropdown items count

How was this patch tested?

Manual and unit tests (267/267 success)

Please review Ambari Contributing Guide before opening a pull request.

@aBabiichuk please review it.

@asfgit
Copy link

asfgit commented Apr 11, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1755/
Test PASSed.

@asfgit
Copy link

asfgit commented Apr 11, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1759/
Test FAILed.
Test FAILured.

@aBabiichuk aBabiichuk self-requested a review April 11, 2018 10:28
Copy link
Contributor

@aBabiichuk aBabiichuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • is it expected that Undo and Redo dropdowns aren't styles the same as History one?
  • labels formatting is not changed

…re - Add history style for redo and undo list. Fixing empty list items.
@asfgit
Copy link

asfgit commented Apr 12, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1802/
Test FAILed.
Test FAILured.

@aBabiichuk
Copy link
Contributor

2512197 [INFO] ambari-logsearch ................................... SUCCESS [ 0.556 s] 2512197 [INFO] Ambari Logsearch Appender .......................... SUCCESS [ 0.570 s] 2512197 [INFO] Ambari Logsearch Config Api ........................ SUCCESS [ 0.977 s] 2512197 [INFO] Ambari Logsearch Config Zookeeper .................. SUCCESS [ 0.314 s] 2512197 [INFO] Ambari Logsearch Log Feeder Plugin Api ............. SUCCESS [ 0.807 s] 2512197 [INFO] Ambari Logsearch Log Feeder ........................ SUCCESS [ 17.204 s] 2512197 [INFO] Ambari Logsearch Web ............................... SUCCESS [03:33 min] 2512197 [INFO] Ambari Logsearch Server ............................ SUCCESS [ 21.215 s] 2512197 [INFO] Ambari Logsearch Assembly .......................... SUCCESS [ 0.148 s] 2512197 [INFO] Ambari Logsearch Integration Test .................. SUCCESS [ 3.310 s]

@aBabiichuk aBabiichuk merged commit 4f93c3c into apache:trunk Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants