Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1963][Spark]: Do not relocate the org.apache.thrift.TException #1965

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

GavinH1984
Copy link
Contributor

Why are the changes needed?

Close #1963.

Brief change log

  • exclude org.apache.thrift.TException during shade amoro spark.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:mixed-spark Spark module for Mixed Format type:build labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@baiyangtx baiyangtx changed the title fix mix-iceberg format with hive metastore not working on spark issue. [AMORO-1963][Spark]: Do not relocate the org.apache.thrift.TException Sep 13, 2023
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution. This will be released with 0.5.1 version.

@baiyangtx baiyangtx merged commit edd83db into apache:master Sep 13, 2023
6 checks passed
@baiyangtx baiyangtx mentioned this pull request Sep 12, 2023
56 tasks
@GavinH1984 GavinH1984 deleted the fix-1963 branch December 21, 2023 16:15
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…n` (apache#1965)

fix mix-iceberg format with hive metastore not working on spark issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-spark Spark module for Mixed Format type:build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mix-iceberg format with hive metastore not working on spark
2 participants