-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2266] Improve combined data reader performance #2268
Conversation
Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2268 +/- ##
============================================
+ Coverage 52.40% 52.47% +0.06%
- Complexity 4127 4140 +13
============================================
Files 500 501 +1
Lines 28936 28975 +39
Branches 2825 2829 +4
============================================
+ Hits 15165 15205 +40
- Misses 12537 12540 +3
+ Partials 1234 1230 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/StructLikeFunnel.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/StructLikeFunnel.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/netease/arctic/io/TestIcebergCombinedReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM |
* [AMORO-2266] Improve combined data reader performance Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Add doc * Fix spotless apply * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix structLike serialize * Fix `rewrittenDataRecordCnt` to constructor * Add test case for various types * Fix test name and add assert * Fix comment * Move readIdentifierData() to CombinedDeleteFilter * Remove StructLikeWrapper * Fix comment * Fix comment and add test * Add units test * fix log Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix filterEqDelete trigger logic * Add parameter FILTER_EQ_DELETE_TRIGGER_RECORD_COUNT * Fix test --------- Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> (cherry picked from commit ad8fedb)
* [AMORO-2266] Improve combined data reader performance Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Add doc * Fix spotless apply * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix structLike serialize * Fix `rewrittenDataRecordCnt` to constructor * Add test case for various types * Fix test name and add assert * Fix comment * Move readIdentifierData() to CombinedDeleteFilter * Remove StructLikeWrapper * Fix comment * Fix comment and add test * Add units test * fix log Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix filterEqDelete trigger logic * Add parameter FILTER_EQ_DELETE_TRIGGER_RECORD_COUNT * Fix test --------- Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> (cherry picked from commit ad8fedb) Signed-off-by: zhoujinsong <463763777@qq.com>
* [AMORO-2266] Improve combined data reader performance Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Add doc * Fix spotless apply * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix structLike serialize * Fix `rewrittenDataRecordCnt` to constructor * Add test case for various types * Fix test name and add assert * Fix comment * Move readIdentifierData() to CombinedDeleteFilter * Remove StructLikeWrapper * Fix comment * Fix comment and add test * Add units test * fix log Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix filterEqDelete trigger logic * Add parameter FILTER_EQ_DELETE_TRIGGER_RECORD_COUNT * Fix test --------- Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
Why are the changes needed?
Close #2266 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation