[AMORO-2266] Improve combined data reader performance #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
github-actions
bot
added
module:core
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2268 +/- ##
============================================
+ Coverage 52.40% 52.47% +0.06%
- Complexity 4127 4140 +13
============================================
Files 500 501 +1
Lines 28936 28975 +39
Branches 2825 2829 +4
============================================
+ Hits 15165 15205 +40
- Misses 12537 12540 +3
+ Partials 1234 1230 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
shidayang
reviewed
Nov 10, 2023
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/StructLikeFunnel.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/StructLikeFunnel.java
Outdated
Show resolved
Hide resolved
shidayang
reviewed
Nov 13, 2023
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/GenericCombinedIcebergDataReader.java
Outdated
Show resolved
Hide resolved
shidayang
reviewed
Nov 13, 2023
core/src/test/java/com/netease/arctic/io/TestIcebergCombinedReader.java
Outdated
Show resolved
Hide resolved
zhoujinsong
reviewed
Nov 14, 2023
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/reader/CombinedDeleteFilter.java
Outdated
Show resolved
Hide resolved
shidayang
approved these changes
Nov 14, 2023
|
LGTM |
hameizi
pushed a commit
to hameizi/arctic
that referenced
this pull request
Nov 28, 2023
* [AMORO-2266] Improve combined data reader performance Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Add doc * Fix spotless apply * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix structLike serialize * Fix `rewrittenDataRecordCnt` to constructor * Add test case for various types * Fix test name and add assert * Fix comment * Move readIdentifierData() to CombinedDeleteFilter * Remove StructLikeWrapper * Fix comment * Fix comment and add test * Add units test * fix log Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix filterEqDelete trigger logic * Add parameter FILTER_EQ_DELETE_TRIGGER_RECORD_COUNT * Fix test --------- Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> (cherry picked from commit ad8fedb)
zhoujinsong
pushed a commit
that referenced
this pull request
Dec 19, 2023
* [AMORO-2266] Improve combined data reader performance Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Add doc * Fix spotless apply * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix structLike serialize * Fix `rewrittenDataRecordCnt` to constructor * Add test case for various types * Fix test name and add assert * Fix comment * Move readIdentifierData() to CombinedDeleteFilter * Remove StructLikeWrapper * Fix comment * Fix comment and add test * Add units test * fix log Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix filterEqDelete trigger logic * Add parameter FILTER_EQ_DELETE_TRIGGER_RECORD_COUNT * Fix test --------- Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> (cherry picked from commit ad8fedb) Signed-off-by: zhoujinsong <463763777@qq.com>
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
* [AMORO-2266] Improve combined data reader performance Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Add doc * Fix spotless apply * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * [AMORO-2266] Use guava bloom filter Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix structLike serialize * Fix `rewrittenDataRecordCnt` to constructor * Add test case for various types * Fix test name and add assert * Fix comment * Move readIdentifierData() to CombinedDeleteFilter * Remove StructLikeWrapper * Fix comment * Fix comment and add test * Add units test * fix log Signed-off-by: Qishang Zhong <zhongqishang@gmail.com> * Fix filterEqDelete trigger logic * Add parameter FILTER_EQ_DELETE_TRIGGER_RECORD_COUNT * Fix test --------- Signed-off-by: Qishang Zhong <zhongqishang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2266 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation