[ARCTIC-985] Introduce Table Blocker to implement concurrency controll between Writing and Optimizing #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:core
wangtaohz
changed the title
2.implement BaseTableBlockerManager
github-actions
bot
added
module:ams-server
block adapt spark writer
wangtaohz
commented
Jan 17, 2023
spark/v3.1/spark/src/main/java/com/netease/arctic/spark/writer/KeyedSparkBatchWrite.java
Show resolved
Hide resolved
baiyangtx
requested changes
Feb 1, 2023
spark/v3.1/spark/src/main/java/com/netease/arctic/spark/table/ArcticSparkTable.java
Outdated
Show resolved
Hide resolved
spark/v3.1/spark/src/main/java/com/netease/arctic/spark/writer/KeyedSparkBatchWrite.java
Show resolved
Hide resolved
spark/v3.1/spark/src/main/java/com/netease/arctic/spark/writer/UnkeyedSparkBatchWrite.java
Show resolved
Hide resolved
2.thrift API renewBlocker return expirationTime
baiyangtx
approved these changes
Feb 1, 2023
baiyangtx
approved these changes
Feb 2, 2023
This was referenced Apr 21, 2023
3 tasks
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…l between Writing and Optimizing (#986) * Add API of Table Blocker * 1.generate thrift API 2.implement BaseTableBlockerManager * implement * fix test * add unit test * fix * clear blockers * block optimize * fix MockArcticMetastoreServer * block adapt spark writer * fix blocker renew too short * fix ams unit test * fix checkstyle * add finally in abort merhod * add unit test for core * block with properties * add merge into release block * check blocker after get current change snapshot id * change BaseBlocker to RenewableBlocker * use BlockerFactory * fix comment * fix checkstyle * remove useless table properties * file info cache get files with snapshot * simplify RenewableBlocker * fix minor optimize plan * fix writer in ams-server unit test * fix NPE * change log * change ams-server maven-surefire-plugin to version 2.19 * change getblocker to createFactory * RenewableBlocker not call renew async in constructor * remove useless import * 1.add blocker timeout into RenewableBlocker 2.thrift API renewBlocker return expirationTime * fix unit test * optimize spark write * fix checkstyle * fix checkstyle * remove appId --------- Co-authored-by: jinsilei <jinsilei@corp.netease.com> Co-authored-by: PlanetWalker <52364847+hellojinsilei@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #985
Brief change log
TableBlockerTableBlockerTableBlockerin AMSTableBlockerHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation