Checkstyle #41
Closed
Checkstyle #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There a bunch of new image files (svg, ...) I dont think that this is related to 'checkstyle'. The other files:
Have to think about the images. The rest is fine for merge. |
|
The SVGs shouldnt contain the "Generator" comment, I'll fix that. *.odg? OpenOffice Draw? Maybe we should place a readme into doc/images how to create/modify a SVG ("use Draw, Export ....") |
|
I found a comment in hibgraph.svg: "Helvetica is a registered trademark of Linotype AG". |
|
Some of the SVGs are produced by directly by yEd. I guess they're the ones that miss "Generator". I'll check them and amend accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that checkstyle rules are sync'ed with Ant, here come the consequences 馃槂
I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for an update...