Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

APEXCORE-735 Upgrade maven-dependency-plugin #533

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

vrozov
Copy link
Member

@vrozov vrozov commented May 31, 2017

@tweise @PramodSSImmaneni Please review

@vrozov
Copy link
Member Author

vrozov commented Jun 7, 2017

@tweise @PramodSSImmaneni Please review

@vrozov
Copy link
Member Author

vrozov commented Jun 10, 2017

testing apache jenkins

@vrozov vrozov closed this Jun 10, 2017
@vrozov vrozov reopened this Jun 10, 2017
@asfgit
Copy link

asfgit commented Jun 10, 2017

Can one of the admins verify this patch?

@vrozov vrozov closed this Jun 10, 2017
@vrozov
Copy link
Member Author

vrozov commented Jun 10, 2017

another jenkins test

@vrozov vrozov reopened this Jun 10, 2017
@asfgit
Copy link

asfgit commented Jun 10, 2017

Can one of the admins verify this patch?

@vrozov vrozov closed this Jun 10, 2017
@vrozov vrozov reopened this Jun 10, 2017
@asfgit
Copy link

asfgit commented Jun 10, 2017

Can one of the admins verify this patch?

@vrozov vrozov closed this Jun 10, 2017
@vrozov vrozov reopened this Jun 10, 2017
@asfgit
Copy link

asfgit commented Jun 10, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Apex_Core_PR/848/

@vrozov vrozov closed this Jun 11, 2017
@vrozov vrozov reopened this Jun 11, 2017
@asfgit
Copy link

asfgit commented Jun 11, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Apex_Core_PR/849/

@pramodin
Copy link
Contributor

@vrozov the tests seem to be succeeding, why is asfgit asking admins to verify. Is it an automated message. Haven't seen this before.

@vrozov
Copy link
Member Author

vrozov commented Jun 11, 2017

@PramodSSImmaneni There was a change on the Apache Jenkins side that caused the change to the Jenkins plugin that Apex uses for PR trigger. Please see my email to dev@apex. The message "Can one of the admins verify this patch?" should be suppressed now, as it was caused by empty whitelist on the new Jenkins PR plugin.

@vrozov
Copy link
Member Author

vrozov commented Jun 11, 2017

test this please

@@ -99,7 +99,7 @@
</descriptors>
<archiverConfig>
<defaultDirectoryMode>0755</defaultDirectoryMode>
</archiverConfig>
</archiverConfig>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid this and the other formatting changes. They could be made in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is automated IDE setting that strips trailing white spaces.

@pramodin
Copy link
Contributor

Can you rebase

@vrozov
Copy link
Member Author

vrozov commented Jun 12, 2017

done

@asfgit asfgit merged commit 5f79cb7 into apache:master Jun 12, 2017
@vrozov vrozov deleted the APEXCORE-735 branch July 5, 2017 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants