This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
APEXCORE-747 Provide additional ToStringStyle options #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodin
reviewed
Jun 26, 2017
| super(); | ||
| } | ||
|
|
||
| private static class ShortClassNameToStringStyle extends ToStringStyle |
There was a problem hiding this comment.
Why can't these directly extend apache ToStringStyle
pramodin
reviewed
Jun 26, 2017
| import org.apache.hadoop.classification.InterfaceStability.Evolving; | ||
|
|
||
| @Evolving | ||
| public abstract class ToStringStyle extends org.apache.commons.lang.builder.ToStringStyle |
There was a problem hiding this comment.
Why does this class need to extend apache ToStringStyle. Looks like this is a container of other StringStyles.
There was a problem hiding this comment.
It is a base common class for Apex ToStringStyle. In future, if we want to modify common behavior for all ToStringStyle classes, it can be done in this class.
There was a problem hiding this comment.
Sounds good. I will merge it tomorrow giving others a chance to look and comment.
|
Can you rebase |
|
Done. |
|
Did you push? Still seeing it on top of a prior commit. |
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PramodSSImmaneni Please review