Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

APEXCORE-747 Provide additional ToStringStyle options #550

Merged
merged 1 commit into from
Jun 27, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.apex.common.util;

import org.apache.hadoop.classification.InterfaceStability.Evolving;

@Evolving
public abstract class ToStringStyle extends org.apache.commons.lang.builder.ToStringStyle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this class need to extend apache ToStringStyle. Looks like this is a container of other StringStyles.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a base common class for Apex ToStringStyle. In future, if we want to modify common behavior for all ToStringStyle classes, it can be done in this class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I will merge it tomorrow giving others a chance to look and comment.

{
public static final ToStringStyle SHORT_CLASS_NAME_STYLE = new ShortClassNameToStringStyle();
public static final ToStringStyle SIMPLE_SHORT_CLASS_NAME_STYLE = new SimpleShortClassNameToStringStyle();
public static final ToStringStyle DEFAULT = SHORT_CLASS_NAME_STYLE;

private ToStringStyle()
{
super();
}

private static class ShortClassNameToStringStyle extends ToStringStyle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't these directly extend apache ToStringStyle

{
private ShortClassNameToStringStyle()
{
super();
setUseShortClassName(true);
}
}

private static class SimpleShortClassNameToStringStyle extends ShortClassNameToStringStyle
{
private SimpleShortClassNameToStringStyle()
{
super();
setFieldSeparatorAtStart(false);
setFieldSeparatorAtEnd(false);
}
}
}