This repository has been archived by the owner on May 12, 2021. It is now read-only.
APEXMALHAR-2120 #resolve #comment solve problems of KafkaInputOperato… #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Before | ||
| public void before() | ||
| { | ||
| FileUtils.deleteQuietly(new File(APPLICATION_PATH)); | ||
| tupleCollection.clear(); | ||
| //FileUtils.deleteQuietly(new File(APPLICATION_PATH)); |
There was a problem hiding this comment.
The different test case/test Scenario use difference directory. So it is not necessary to delete the directory
There was a problem hiding this comment.
Tests should always delete in case it was leftover from previous run.
brightchen
force-pushed
the
APEXMALHAR-2120
branch
3 times, most recently
from
f73820a
to
252a701
Compare
brightchen
force-pushed
the
APEXMALHAR-2120
branch
from
252a701
to
770119d
Compare
|
@siyuanh The NullPointerException issue should be fixed, I've tested more than 10 times. Please review and merger |
|
|
||
| t.join(); | ||
|
|
||
| logger.info("Number of received/expected tuples: {}/{}, testName: {}, tuples: \n{}", tupleCollection.size(), expectedReceiveCount, testName, tupleCollection); |
There was a problem hiding this comment.
Log this only when something goes wrong
…rTest and AbstractKafkaInputOperator
brightchen
force-pushed
the
APEXMALHAR-2120
branch
from
770119d
to
f2b7a85
Compare
|
@siyuanh Please review and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rTest and AbstractKafkaInputOperator