Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo #1561

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 7, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test( route_with_uri_uris_test with )ginkgo

@codecov-io
Copy link

codecov-io commented Mar 7, 2021

Codecov Report

Merging #1561 (d871880) into master (9130e09) will increase coverage by 3.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
+ Coverage   70.18%   73.24%   +3.05%     
==========================================
  Files         130       86      -44     
  Lines        5340     2321    -3019     
  Branches      549      583      +34     
==========================================
- Hits         3748     1700    -2048     
+ Misses       1344      621     -723     
+ Partials      248        0     -248     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 73.24% <ø> (+1.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/constants.ts 100.00% <0.00%> (ø)
web/src/pages/Route/components/Step1/MetaView.tsx 100.00% <0.00%> (ø)
api/internal/handler/service/service.go
api/internal/handler/data_loader/route_export.go
api/internal/core/store/query.go
api/internal/core/storage/etcd.go
api/internal/filter/request_id.go
api/internal/handler/route/route.go
api/internal/handler/consumer/consumer.go
api/internal/handler/global_rule/global_rule.go
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9130e09...d871880. Read the comment docs.

Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using table.Entry is better for us

@Jaycean
Copy link
Member Author

Jaycean commented Mar 8, 2021

I think using table.Entry is better for us

Yes, but creating route requires replacing upstream_id
table.entry There is no way to create a new variable.

@nic-chen
Copy link
Member

nic-chen commented Mar 8, 2021

I think using table.Entry is better for us

Yes, but creating route requires replacing upstream_id
table.entry There is no way to create a new variable.

the old test cases are all table driven...

@Jaycean
Copy link
Member Author

Jaycean commented Mar 8, 2021

I think using table.Entry is better for us

Yes, but creating route requires replacing upstream_id
table.entry There is no way to create a new variable.

the old test cases are all table driven...

It's my problem. I'll revise it

@nic-chen nic-chen merged commit 6b795db into apache:master Mar 9, 2021
@nic-chen
Copy link
Member

nic-chen commented Mar 9, 2021

merged. thanks very much. @Jaycean

@Jaycean Jaycean deleted the rewrite-e2e-test-route-with-uri-uris-test-with-ginkgo branch March 10, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants