Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Rewrite all E2E tests using the Ginkgo #1500

Open
23 of 35 tasks
Jaycean opened this issue Feb 23, 2021 · 9 comments
Open
23 of 35 tasks

Feat: Rewrite all E2E tests using the Ginkgo #1500

Jaycean opened this issue Feb 23, 2021 · 9 comments
Labels
good first issue Good for newcomers

Comments

@Jaycean
Copy link
Member

Jaycean commented Feb 23, 2021

Feature request

Rewrite all E2E tests using the Ginkgo.

There are a lot of E2E tests that need to be rewritten, so we record the rewriting of E2E in this issue.

E2E test rewrite list (by file name)

@Jaycean
Copy link
Member Author

Jaycean commented Feb 23, 2021

The PR and issue of the completed E2E can be associated and recorded.

cc @nic-chen @starsz @imjoey

@starsz
Copy link
Contributor

starsz commented Feb 23, 2021

Yeah. Much appreciated.
As far as I know, @nic-chen had finished part of them but hadn't created PR.

@nic-chen
Copy link
Member

Thanks @Jaycean
I think we could list a todo list by module

@Jaycean
Copy link
Member Author

Jaycean commented Feb 23, 2021

Thanks @Jaycean
I think we could list a todo list by module

OK, I'll make the list by E2E test file name

@Jaycean
Copy link
Member Author

Jaycean commented Feb 23, 2021

I think we can add the name of the person who is rewriting the file after each todolist, so as to avoid repeated development.

such as

@bisakhmondal
Copy link
Member

Hi @Jaycean, would you mind if I rewrite the route import test in the e2enew test suite :)

@Jaycean
Copy link
Member Author

Jaycean commented Mar 11, 2021

Hi @Jaycean, would you mind if I rewrite the route import test in the e2enew test suite :)

Thank you very much. It has been allocated in to do list. You can @ me if you have any questions.

@bisakhmondal
Copy link
Member

Hey @Jaycean, I have rewritten the test using ginkgo for the mentioned test suite. Now I am facing issues to test it locally before opening a PR. I am following the doc to set up the environment for the testing using docker-compose. It's failing, so opened issue #1581. It seems, for now, its better to go with installing the required dependencies locally. Pushing the changes soon :) Thank you

@Jaycean
Copy link
Member Author

Jaycean commented Mar 12, 2021

Hey @Jaycean, I have rewritten the test using ginkgo for the mentioned test suite. Now I am facing issues to test it locally before opening a PR. I am following the doc to set up the environment for the testing using docker-compose. It's failing, so opened issue #1581. It seems, for now, its better to go with installing the required dependencies locally. Pushing the changes soon :) Thank you

Thank you for your contribution. I have replied to you in issue. If you have more questions, you can ask them in issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants