Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite route-with-jwt-plugin-test using ginkgo #1781

Closed

Conversation

bisakhmondal
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues
#1500

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 15, 2021

Deploy preview for apisix-dashboard ready!

Built with commit a559218

https://deploy-preview-1781--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member

@nic-chen same pending here

@nic-chen
Copy link
Member

@bisakhmondal
please push a new commit to trigger ci, if fail again, I think we may need to create a new PR

@bisakhmondal
Copy link
Member Author

Okay

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #1781 (802368a) into master (1d2bc54) will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1781      +/-   ##
==========================================
- Coverage   72.13%   71.46%   -0.68%     
==========================================
  Files         132       47      -85     
  Lines        5721     3129    -2592     
  Branches      649        0     -649     
==========================================
- Hits         4127     2236    -1891     
+ Misses       1350      649     -701     
  Partials      244      244              
Flag Coverage Δ
backend-e2e-test 62.25% <ø> (+0.07%) ⬆️
backend-e2e-test-ginkgo 49.05% <ø> (-0.12%) ⬇️
backend-unit-test 52.23% <ø> (-0.06%) ⬇️
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 86.22% <0.00%> (-1.73%) ⬇️
web/src/components/Plugin/UI/basic-auth.tsx
web/src/pages/Route/components/Step2/index.tsx
web/src/pages/SSL/List.tsx
web/src/pages/SSL/Create.tsx
web/src/components/Plugin/UI/plugin.tsx
web/src/components/Footer/index.tsx
.../components/PluginOrchestration/DrawPluginStyle.ts
...pages/SSL/components/CertificateUploader/index.tsx
web/src/pages/PluginTemplate/service.ts
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2bc54...802368a. Read the comment docs.

@juzhiyuan
Copy link
Member

@bisakhmondal Hi, please sync codes to your branch, the FE CI will get fixed.

@nic-chen
Copy link
Member

hi @bisakhmondal
I think you could try to create a new PR to resolve Expected

@bisakhmondal
Copy link
Member Author

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants