Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: using curl command instead of wget #1836

Merged
merged 2 commits into from
May 3, 2021

Conversation

dmsolr
Copy link
Member

@dmsolr dmsolr commented Apr 30, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Using curl -so instead of wget -P because curl is more general.

Please update this section with detailed description.

Related issues

fix/resolve #1

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 30, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 880349d

https://deploy-preview-1836--apisix-dashboard.netlify.app

@dmsolr dmsolr changed the title Update Makefile build: using curl command instead of wget Apr 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (b4f3720) to head (880349d).
Report is 357 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1836      +/-   ##
==========================================
- Coverage   71.10%   70.97%   -0.13%     
==========================================
  Files         173      173              
  Lines        6202     6202              
  Branches      711      710       -1     
==========================================
- Hits         4410     4402       -8     
- Misses       1536     1543       +7     
- Partials      256      257       +1     
Flag Coverage Δ
backend-e2e-test 45.58% <ø> (-0.07%) ⬇️
backend-e2e-test-ginkgo 48.34% <ø> (-0.19%) ⬇️
backend-unit-test 52.47% <ø> (ø)
frontend-e2e-test 72.07% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@starsz starsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@juzhiyuan
Copy link
Member

@dmsolr Please check the failuer case

@dmsolr
Copy link
Member Author

dmsolr commented May 3, 2021

@dmsolr Please check the failuer case

Hi @juzhiyuan It is fixed, please recheck.

@juzhiyuan juzhiyuan merged commit d7e08cb into apache:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants