Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n for TCP in Upstream #1963

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jul 1, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Fixed i18n in the TCP failure field of the upstream component.

Related issues
resolve #1959

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 1, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: c23cb4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60ddd6d01157aa0008b42de0

😎 Browse the preview: https://deploy-preview-1963--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

Codecov Report

Merging #1963 (c23cb4f) into master (3cfc327) will decrease coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   66.79%   64.01%   -2.79%     
==========================================
  Files         182      122      -60     
  Lines        6575     3154    -3421     
  Branches      753      753              
==========================================
- Hits         4392     2019    -2373     
+ Misses       1907     1135     -772     
+ Partials      276        0     -276     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 64.01% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/log/log.go
api/internal/handler/consumer/consumer.go
api/internal/handler/ssl/ssl.go
api/internal/handler/healthz/healthz.go
api/cmd/root.go
api/internal/utils/runtime/runtime.go
api/internal/core/migrate/dataset.go
api/internal/handler/label/label.go
api/cmd/service.go
.../internal/handler/authentication/authentication.go
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfc327...c23cb4f. Read the comment docs.

@guoqqqi
Copy link
Member Author

guoqqqi commented Jul 8, 2021

@liuxiran Please help me look at it when you have time

@Jaycean Jaycean requested a review from liuxiran July 21, 2021 03:28
@liuxiran liuxiran merged commit ff0e8bf into apache:master Jul 25, 2021
@guoqqqi guoqqqi deleted the fix-i18n-for-upstream branch July 26, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a problem with the dashboard display
6 participants