Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route): add operators #2022

Merged
merged 8 commits into from
Aug 7, 2021
Merged

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

support all operators in route vars field .

Related issues

fix #2014

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 1, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 48591b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/610d3817fcbfd0000735b7de

😎 Browse the preview: https://deploy-preview-2022--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2021

Codecov Report

Merging #2022 (48591b9) into master (af85591) will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
+ Coverage   63.52%   63.96%   +0.44%     
==========================================
  Files         121      121              
  Lines        3213     3194      -19     
  Branches      779      773       -6     
==========================================
+ Hits         2041     2043       +2     
+ Misses       1172     1151      -21     
Flag Coverage Δ
frontend-e2e-test 63.96% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pages/Route/components/Step1/MatchingRulesView.tsx 64.77% <100.00%> (+11.50%) ⬆️
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af85591...48591b9. Read the comment docs.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify unchanged codes.

Co-authored-by: liuxiran <liuxiran@apache.org>
@liuxiran
Copy link
Contributor

liuxiran commented Aug 2, 2021

It would be better to add a test case to verify whether we have covered add the operators

@Baoyuantop
Copy link
Contributor Author

It would be better to add a test case to verify whether we have covered add the operators

I am supplementing the test part

@guoqqqi
Copy link
Member

guoqqqi commented Aug 6, 2021

LGTM! cc @liuxiran @iamayushdas please have a look

web/src/pages/Route/locales/zh-CN.ts Outdated Show resolved Hide resolved
@juzhiyuan juzhiyuan merged commit f16d8ba into apache:master Aug 7, 2021
@Baoyuantop Baoyuantop deleted the fix-route-rule branch August 7, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support all operators in vars field
7 participants