Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add el7 in package name #2074

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Aug 16, 2021

Signed-off-by: imjoey majunjie@apache.org

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The package name of apisix-dashboard in CentOS7 has been added with the OS distribution name el7, see api7/apisix-build-tools#67 for details. So this PR is going to change the relevant rpm name to apisix-dashboard-${version}-0.el7.x86_64.rpm from the original apisix-dashboard-${version}-0.x86_64.rpm. This PR will also fix the CI failures due to the stale package name.

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: imjoey <majunjie@apache.org>
@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: b904edb

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/611a57e68bbb04000768b164

😎 Browse the preview: https://deploy-preview-2074--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #2074 (09594a4) into master (cb5f4fa) will not change coverage.
The diff coverage is n/a.

❗ Current head 09594a4 differs from pull request most recent head b904edb. Consider uploading reports for the commit b904edb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2074   +/-   ##
=======================================
  Coverage   71.07%   71.07%           
=======================================
  Files          60       60           
  Lines        3779     3779           
=======================================
  Hits         2686     2686           
  Misses        809      809           
  Partials      284      284           
Flag Coverage Δ
backend-e2e-test 46.57% <ø> (-0.77%) ⬇️
backend-e2e-test-ginkgo 49.24% <ø> (+0.21%) ⬆️
backend-unit-test 52.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5f4fa...b904edb. Read the comment docs.

@imjoey
Copy link
Member Author

imjoey commented Aug 16, 2021

It's kind of urgent. Ping @juzhiyuan @starsz @Jaycean @liuxiran @nic-chen. PTAL, thanks.

@liuxiran liuxiran merged commit d1efdaf into apache:master Aug 17, 2021
@imjoey imjoey deleted the ci/new_centos7_rpm branch August 17, 2021 00:58
iamayushdas pushed a commit to iamayushdas/apisix-dashboard that referenced this pull request Aug 17, 2021
Signed-off-by: imjoey <majunjie@apache.org>
iamayushdas pushed a commit to iamayushdas/apisix-dashboard that referenced this pull request Aug 17, 2021
Signed-off-by: imjoey <majunjie@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants