Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate rules in Apisix Dashboard is same as Apisix api #2085

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

iamayushdas
Copy link
Contributor

@iamayushdas iamayushdas commented Aug 24, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2057

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 791647a

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6127028e0cfc9f00077ad242

😎 Browse the preview: https://deploy-preview-2085--apisix-dashboard.netlify.app

@iamayushdas
Copy link
Contributor Author

cc @liuxiran @guoqqqi @juzhiyuan

@liuxiran
Copy link
Contributor

@liuxiran
Copy link
Contributor

Hi @iamayushdas , would you please add test case for your changes?

just add assertion to check a route name with 101 characters can be added to this test case,

@iamayushdas
Copy link
Contributor Author

Sure sure

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #2085 (914c65c) into master (fb78963) will decrease coverage by 3.81%.
The diff coverage is n/a.

❗ Current head 914c65c differs from pull request most recent head 791647a. Consider uploading reports for the commit 791647a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
- Coverage   68.87%   65.05%   -3.82%     
==========================================
  Files         181      121      -60     
  Lines        7010     3231    -3779     
  Branches      787      787              
==========================================
- Hits         4828     2102    -2726     
+ Misses       1898     1129     -769     
+ Partials      284        0     -284     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 65.05% <ø> (-1.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/components/Step1/MetaView.tsx 100.00% <ø> (ø)
...pages/Route/components/Step1/MatchingRulesView.tsx 26.13% <0.00%> (-38.64%) ⬇️
web/src/pages/Route/transform.ts 72.41% <0.00%> (-7.48%) ⬇️
web/src/pages/Route/Create.tsx 82.92% <0.00%> (-1.63%) ⬇️
web/src/pages/Route/List.tsx 82.84% <0.00%> (-1.19%) ⬇️
api/internal/utils/closer.go
api/internal/filter/schema.go
api/internal/handler/label/label.go
api/internal/core/storage/storage_mock.go
api/internal/handler/consumer/consumer.go
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb78963...791647a. Read the comment docs.

@iamayushdas
Copy link
Contributor Author

@liuxiran its done

Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liuxiran liuxiran merged commit 59ea8c6 into apache:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure validate rules in Apisix Dashboard is same as Apisix api
7 participants