ci: optimize build rpm workflow with apisix-build-tools v2.2.0 #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
imjoey
requested changes
Sep 8, 2021
|
Hi @qsliu2017, happy to see you committed this PR. I've closed the #2132, which did the same thing. Let's work on this. Thanks. |
imjoey
changed the title
Thank you so much, I've updated build tool version to v2.2.0 |
imjoey
requested review from
starsz,
nic-chen,
bzp2010,
gxthrj and
tzssangglass
starsz
approved these changes
Sep 9, 2021
starsz
requested changes
Sep 9, 2021
starsz
approved these changes
Sep 10, 2021
nic-chen
approved these changes
Sep 10, 2021
tzssangglass
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
As discussed in #2072, we delay using buildx in
auto-build-rpmworkflow since it relates to the build tool. Now we have updated the build tool(api7/apisix-build-tools#74), it's time to make this change!Related issues
fix #2128
Checklist: