Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gzip plugin schema typo #2142

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Sep 18, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Fix plugin schema of gzip typo, change minItem ot minItems. That broken schema will crash frontend page.

Related issues

fix #2088

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 self-assigned this Sep 18, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2142 (76734f4) into master (65e2528) will decrease coverage by 14.77%.
The diff coverage is n/a.

❗ Current head 76734f4 differs from pull request most recent head af9c3ea. Consider uploading reports for the commit af9c3ea to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2142       +/-   ##
===========================================
- Coverage   67.48%   52.70%   -14.78%     
===========================================
  Files         126       38       -88     
  Lines        3294     2935      -359     
  Branches      802        0      -802     
===========================================
- Hits         2223     1547      -676     
- Misses       1071     1194      +123     
- Partials        0      194      +194     
Flag Coverage Δ
backend-unit-test 52.70% <ø> (?)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Upstream/components/Step1.tsx
...mponents/Upstream/components/active-check/Host.tsx
web/src/pages/SSL/service.ts
web/src/pages/Route/components/Step1/MetaView.tsx
web/src/components/Plugin/PluginPage.tsx
web/src/components/Plugin/UI/basic-auth.tsx
web/src/components/RightContent/index.tsx
web/src/components/Upstream/constant.ts
web/src/components/Footer/index.tsx
web/src/app.tsx
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e2528...af9c3ea. Read the comment docs.

@bzp2010 bzp2010 merged commit f8d7f1e into apache:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support gzip plugin in dashboard
6 participants