Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upstream): remove default port for upstream health check #2278

Merged
merged 2 commits into from
Jan 4, 2022
Merged

chore(upstream): remove default port for upstream health check #2278

merged 2 commits into from
Jan 4, 2022

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Jan 2, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Remove upstream health check default port.

Please update this section with detailed description.

Related issues

fix #2186

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@zaunist zaunist marked this pull request as ready for review January 2, 2022 17:15
@codecov-commenter
Copy link

Codecov Report

Merging #2278 (bb33e79) into master (bec322a) will increase coverage by 3.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
+ Coverage   64.97%   68.07%   +3.09%     
==========================================
  Files         184      127      -57     
  Lines        7275     3370    -3905     
  Branches      829      829              
==========================================
- Hits         4727     2294    -2433     
+ Misses       2263     1076    -1187     
+ Partials      285        0     -285     
Flag Coverage Δ
backend-e2e-test ?
backend-unit-test ?
frontend-e2e-test 68.07% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/Upstream/components/active-check/Port.tsx 100.00% <ø> (ø)
web/src/helpers.tsx 70.49% <0.00%> (-3.28%) ⬇️
api/internal/filter/logging.go
api/internal/handler/label/label.go
api/internal/handler/upstream/upstream.go
api/internal/utils/closer.go
api/internal/handler/migrate/migrate.go
api/internal/core/store/store_mock.go
api/internal/utils/version.go
api/internal/log/log.go
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec322a...bb33e79. Read the comment docs.

@zaunist
Copy link
Contributor Author

zaunist commented Jan 3, 2022

Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@LiteSun LiteSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit d41ee1e into apache:master Jan 4, 2022
@zaunist zaunist deleted the fix/remove_upstream_default_port branch January 4, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream.checks.active.port should not set to 80 by default
7 participants