feat: allow to enable/disable some plugins #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of plugins for gateway (apisix container) is currently configured
statically in the ConfigMap and there is no way to customize the list.
That means that e.g. `zipkin` plugin for observability is always enabled,
but `opentelemetry` is not and it is not possible to enabled it (easily).
This just a proposal, how it could be done in one way.
I was also thinking about:
```
gateway:
pluginsOverride:
- plugin1
- plugin2
- ...
```
Or instead of adjusting ConfigMap template to allow for swappping it
with `existingConfigMap`, e.g.:
```
gateway:
existingConfigMap: "my-apisix-configmap"
```
Which would cause to not render `apisix-configmap.yaml` at all and
instead switch `configuration` volume to provided custom ConfigMap.
Feedback is welcome.
|
Any possibility for a review and/or discussion, please? One new option that could be useful is: gateway.plugins.enable would add something to the list of default plugins, while disable would remove it. My concern here is - if plugins need to be specified in the list by their priority or if order just doesn't matter. |
|
@mstefany Sorry for the late reply. I got busy. Now I am going over all your proposals and PRs one by one |
|
@mstefany I will approve this PR but the proposal you have, can you create a separate issue and add details in the description so that other maintainers can take a look at the proposal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of plugins for gateway (apisix container) is currently configured statically in the ConfigMap and there is no way to customize the list. That means that e.g.
zipkinplugin for observability is always enabled, butopentelemetryis not and it is not possible to enabled it (easily).This just a proposal, how it could be done in one way.
I was also thinking about:
Or instead of adjusting ConfigMap template to allow for swappping it with
existingConfigMap, e.g.:Which would cause to not render
apisix-configmap.yamlat all and instead switchconfigurationvolume to provided custom ConfigMap.Feedback is welcome.