Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jwt-auth authorization method #1009

Merged
merged 14 commits into from
May 16, 2022
Merged

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented May 9, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Issues: #1001

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan force-pushed the jwtAuth branch 3 times, most recently from ce0c5bf to dbd5268 Compare May 10, 2022 01:39
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a checksum, other contents LGTM

pkg/kube/apisix/apis/config/v2/types.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #1009 (369b388) into master (670d671) will increase coverage by 0.31%.
The diff coverage is 78.18%.

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   31.81%   32.13%   +0.31%     
==========================================
  Files          74       74              
  Lines        7977     8032      +55     
==========================================
+ Hits         2538     2581      +43     
- Misses       5163     5174      +11     
- Partials      276      277       +1     
Impacted Files Coverage Δ
pkg/kube/translation/apisix_route.go 21.07% <0.00%> (-0.36%) ⬇️
pkg/kube/translation/apisix_consumer.go 71.42% <60.00%> (-3.58%) ⬇️
pkg/kube/translation/plugin.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a4166...369b388. Read the comment docs.

pkg/kube/translation/plugin.go Outdated Show resolved Hide resolved
pkg/kube/translation/plugin.go Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

ping @sff0219

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tokers tokers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs to:

  1. JWT Auth Config Reference
  2. How to use it?

pkg/kube/apisix/apis/config/v2/types.go Outdated Show resolved Hide resolved
pkg/kube/apisix/apis/config/v2/types.go Outdated Show resolved Hide resolved
pkg/kube/apisix/apis/config/v2/types.go Outdated Show resolved Hide resolved
pkg/types/apisix/v1/plugin_types.go Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixConsumer.yaml Outdated Show resolved Hide resolved
AlinsRan and others added 4 commits May 12, 2022 22:47
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
@tao12345666333
Copy link
Member

I don't think we need to write a separate document.
Content can be added to this document. https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/practices/enable-authentication-and-restriction.md

@AlinsRan
Copy link
Contributor Author

I don't think we need to write a separate document. Content can be added to this document. https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/practices/enable-authentication-and-restriction.md

I agree.

@tao12345666333 tao12345666333 added this to the 1.5.0 milestone May 13, 2022
@AlinsRan
Copy link
Contributor Author

Missing docs to:

  1. JWT Auth Config Reference
  2. How to use it?

doc: #1018

@tokers tokers changed the title feat: add jwt-auth authorized feat: add jwt-auth authorization method May 16, 2022
@tao12345666333
Copy link
Member

Let's move forward, docs can be tracked with #1018

cc @tokers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

request help: support jwt-auth plugin for ApisixConsumer
5 participants