-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jwt-auth authorization method #1009
Conversation
ce0c5bf
to
dbd5268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a checksum, other contents LGTM
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
+ Coverage 31.81% 32.13% +0.31%
==========================================
Files 74 74
Lines 7977 8032 +55
==========================================
+ Hits 2538 2581 +43
- Misses 5163 5174 +11
- Partials 276 277 +1
Continue to review full report at Codecov.
|
ping @sff0219 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing docs to:
- JWT Auth Config Reference
- How to use it?
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
I don't think we need to write a separate document. |
I agree. |
doc: #1018 |
Type of change:
What this PR does / why we need it:
Issues: #1001
Pre-submission checklist: